feat(test): support glob patterns in --namespace#1321
Open
alliasgher wants to merge 1 commit into
Open
Conversation
Allow --namespace to accept glob patterns (`*`, `?`, character classes) so users with hierarchical Rego packages can match families of namespaces in one flag, e.g. --namespace k8s.simple.*. Patterns are expanded against the namespaces actually loaded into the engine, with literals passing through unchanged. An unmatched pattern errors so typos do not silently turn into a no-op. Fixes open-policy-agent#1141 Signed-off-by: alliasgher <alliasgher123@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow `--namespace` to accept glob patterns (`*`, `?`, character classes) so
users with hierarchical Rego packages can match families of namespaces in
one flag, e.g.:
```
conftest test --namespace 'k8s.simple.*' deployment.yaml
```
Behaviour
engine using `path.Match` semantics, with `.` treated as the segment
separator. So `k8s.simple.*` matches `k8s.simple.deployment`,
`k8s.simple.hpa`, etc., but not `k8s.simple.deployment.foo`.
globs (`--namespace main --namespace 'k8s.simple.*'`).
don't silently turn into a no-op.
Tests
`runner/test_test.go` covers the `hasGlob` predicate and the
`expandNamespaceGlobs` expansion, including dedup, mixed literals/globs,
char classes, and the unmatched-pattern error.
Fixes #1141